Hi Jerin

Thanks for the review.
PSB

From: Jerin Jacob

On Thu, Mar 25, 2021 at 1:51 PM Matan Azrad [off-list ref] wrote:

quoted

Hi Cristian

From: Dumitrescu, Cristian

quoted

Hi Li and Matan,

quoted

-----Original Message-----
From: Li Zhang <redacted>
Sent: Thursday, March 18, 2021 8:58 AM
To: dekelp@nvidia.com; orika@nvidia.com; viacheslavo@nvidia.com;
matan@nvidia.com; shahafs@nvidia.com; lironh@marvell.com; Singh,
Jasvinder [off-list ref]; Thomas Monjalon
[off-list ref]; Yigit, Ferruh [off-list ref];
Andrew Rybchenko [off-list ref]; Dumitrescu,
Cristian [off-list ref]
Cc: dev@dpdk.org; rasland@nvidia.com; roniba@nvidia.com
Subject: [PATCH 2/2] [RFC]: ethdev: manage meter API object
handles by the drivers

quoted

Yes, it changes all API, but very small part in each, will be very easy to align

all the current dpdk components to use this concept.

quoted

quoted

If you guys insist with this proposal, I would like to get more
opinions from other vendors and contributors from within our DPDK

community.

quoted

Yes, more opinions are very welcomed.

This point was discussed to the core in the initial meter RFC.

IMO, IDs helps in managing meter objects more clean way with lookup cost.

Although it is not the main topic here I ask:
What is the difference between pointer to ID for the cost topic? Both are unique IDs actually....

especially, If a non DPDK application, managing the meter ID via some sort of
IPC.

Considering existing APIs and drivers are implemented with ID scheme, I think,
it would be better to give some performance data for changing the scheme.

I was under impression that, Typical number of MAX meter HW objects could
be around 16k something and the number of meter objects created and
destroyed per second will be very low. (In the order to 16k ops per second)
Could you share the practical number of meter HW objects in MLX SoCs and
the number of operations are you are envisioning?

We are talking about 4M HW meters in the next version of mlx5 driver.
The rate of flows(with meter action) creation\deletion can arrive to 200K-300K per second and we are working hard to improve it more.

Can you please give also your opinion about the owner of the ID\pointer?
The main goal of this patch is to move the owner from the application to the driver....




 

quoted

Thanks