Thread (7 messages) 7 messages, 3 authors, 2021-03-30

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log

From: Li, Xiaoyun <hidden>
Date: 2021-03-29 07:07:38

Hi
quoted hunk ↗ jump to hunk
-----Original Message-----
From: Min Hu (Connor) <redacted>
Sent: Monday, March 29, 2021 14:47
To: dev@dpdk.org
Cc: Yigit, Ferruh <redacted>; Li, Xiaoyun <redacted>
Subject: [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log

From: Hongbo Zheng <redacted>

This patch adds more err info for Tx/Rx descriptor query command.

Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
Cc: stable@dpdk.org

Signed-off-by: Hongbo Zheng <redacted>
Signed-off-by: Min Hu (Connor) <redacted>
---
v2:
* Fixed error log info and simply the commit info.
---
 app/test-pmd/cmdline.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
14110eb..f44116b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -16629,7 +16629,8 @@ cmd_show_rx_tx_desc_status_parsed(void
*parsed_result,
 		rc = rte_eth_rx_descriptor_status(res->cmd_pid, res-
quoted
cmd_qid,
 					     res->cmd_did);
 		if (rc < 0) {
-			printf("Invalid queueid = %d\n", res->cmd_qid);
+			printf("Invalid input: queue id = %d, desc id = %d\n",
+			       res->cmd_qid, res->cmd_did);
 			return;
 		}
 		if (rc == RTE_ETH_RX_DESC_AVAIL)
@@ -16642,7 +16643,8 @@ cmd_show_rx_tx_desc_status_parsed(void
*parsed_result,
 		rc = rte_eth_tx_descriptor_status(res->cmd_pid, res-
quoted
cmd_qid,
 					     res->cmd_did);
 		if (rc < 0) {
-			printf("Invalid queueid = %d\n", res->cmd_qid);
+			printf("Invalid input: queue id = %d, desc id = %d\n",
+			       res->cmd_qid, res->cmd_did);
 			return;
 		}
 		if (rc == RTE_ETH_TX_DESC_FULL)
--
2.7.4
Acked-by: Xiaoyun Li <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help