Thanks for comments, new version sent:
http://patchwork.dpdk.org/project/dpdk/patch/20210328131222.16584-1-xuemingl@nvidia.com/

-----Original Message-----
From: Kinsella, Ray <redacted>
Sent: Tuesday, March 23, 2021 5:59 PM
To: Dmitry Kozlyuk <redacted>
Cc: Xueming(Steven) Li <redacted>; dev@dpdk.org; Narcisa Ana Maria Vasile <redacted>; Dmitry
Malloy [off-list ref]; Pallavi Kadam [off-list ref]; Neil Horman [off-list ref]
Subject: Re: [PATCH] eal: update all buses default scan mode



On 23/03/2021 09:57, Dmitry Kozlyuk wrote:

quoted

2021-03-23 09:34 (UTC+0000), Kinsella, Ray:

quoted

On 23/03/2021 09:33, Kinsella, Ray wrote:

quoted

On 22/03/2021 23:32, Dmitry Kozlyuk wrote:

quoted

2021-03-16 20:45 (UTC+0800), Xueming Li:
[...]

[SNIP]

quoted

quoted

quoted

 	rte_mem_page_size;

New function is private to EAL, so it doesn't need exporting.

Right - it is annotated as INTERNAL.

Sorry, let me be clearer - it is being correctly annotated unless I have missed something.

This function is purely internal to librte_eal. It doesn't need to be
added to .map or .def. It also doesn't need __rte_internal, like other
functions in eal_private.h don't need it either.

ok - I get you now - agreed.