Thread (38 messages) 38 messages, 4 authors, 2021-04-28

Re: [dpdk-dev] [PATCH 1/4] vhost: fix uninitialized vhost queue

From: Maxime Coquelin <hidden>
Date: 2021-03-26 15:16:13


On 3/17/21 1:56 PM, Jiayu Hu wrote:
This patch allocates vhost queue by rte_zmalloc() to avoid
undefined values.

Fixes: 8acd7c213353 ("vhost: fix virtqueues metadata allocation")
This is not the right commit. rte_malloc was used prior to it.
quoted hunk ↗ jump to hunk
Signed-off-by: Jiayu Hu <redacted>
---
 lib/librte_vhost/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
index 52ab93d..f6fd001 100644
--- a/lib/librte_vhost/vhost.c
+++ b/lib/librte_vhost/vhost.c
@@ -598,7 +598,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx)
 		if (dev->virtqueue[i])
 			continue;
 
-		vq = rte_malloc(NULL, sizeof(struct vhost_virtqueue), 0);
+		vq = rte_zmalloc(NULL, sizeof(struct vhost_virtqueue), 0);
 		if (vq == NULL) {
 			VHOST_LOG_CONFIG(ERR,
 				"Failed to allocate memory for vring:%u.\n", i);
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help