Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe
From: Jerin Jacob <hidden>
Date: 2021-03-26 11:01:21
On Thu, Mar 25, 2021 at 1:01 AM McDaniel, Timothy [off-list ref] wrote:
quoted
-----Original Message----- From: Jerin Jacob <redacted> Sent: Sunday, March 21, 2021 4:48 AM To: McDaniel, Timothy <redacted> Cc: dpdk-dev <redacted>; Jerin Jacob <redacted>; Van Haaren, Harry [off-list ref]; Ray Kinsella [off-list ref]; Neil Horman [off-list ref]; Rao, Nikhil [off-list ref]; Carrillo, Erik G [off-list ref]; Gujjar, Abhinandan S [off-list ref]; Pavan Nikhilesh [off-list ref]; Hemant Agrawal [off-list ref]; mattias.ronnblom [off-list ref]; Mccarthy, Peter [off-list ref] Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe On Wed, Mar 17, 2021 at 3:49 AM Timothy McDaniel [off-list ref] wrote:quoted
This commit adds dlb v2.5 probe support, and updates parameter parsing. The dlb v2.5 device differs from dlb v2, in that the number of resources (ports, queues, ...) is different, so macros have been added to take the device version into account. This commit also cleans up a few issues in the original dlb2 source: - eliminate duplicate constant definitions - removed unused constant definitions Signed-off-by: Timothy McDaniel <redacted> ---quoted
-#define EVDEV_DLB2_NAME_PMD dlb2_event +#define EVDEV_DLB2_NAME_PMD dlb_eventIs this an intended change? why change the driver's name.Yes, This is an intentional change. We will be using the same driver name going forward, regardless of the hardware version. Internally, we know which version of the hardware is present.
Since the driver name is still driver/event/dlb2. Keep it as same prefix scheme with other drivers.
Thanks, Tim