Thread (20 messages) 20 messages, 5 authors, 2021-03-30

Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

From: Ferruh Yigit <hidden>
Date: 2021-03-24 11:27:22

On 3/24/2021 4:32 AM, Tyler Retzlaff wrote:
On Tue, Mar 23, 2021 at 05:04:08PM +0000, Ferruh Yigit wrote:
quoted
quoted
diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build
index c37b2e377..4353fa6b7 100644
--- a/lib/librte_ethdev/meson.build
+++ b/lib/librte_ethdev/meson.build
@@ -20,8 +20,14 @@ headers = files('rte_ethdev.h',
  	'rte_mtr_driver.h',
  	'rte_tm.h',
  	'rte_tm_driver.h')
+
  indirect_headers += files(
  	'rte_ethdev_core.h',
  	'rte_eth_ctrl.h')
+driver_sdk_headers += files(
+	'ethdev_driver.h',
+	'ethdev_pci.h',
+	'ethdev_vdev.h')
+
  deps += ['net', 'kvargs', 'meter', 'telemetry']
i feel like i missed a reply here.  but just to clarify only ethdev will
be covered by this patch. inclusion of other driver headers was
discussed off list (sorry) and it emerged that it would result in
withdraw a number of driver api/abi that had not been marked as
__rte_internal.

for driver api that were being exported as 'stable' a deprecation notice
will need to be issued in order to make them part of the
driver_sdk_headers. for that reason only ethdev is being made available
under this option for now.

please ack/nack the patch as-is
I am OK the patch for the ethdev part, hence
Acked-by: Ferruh Yigit <redacted>


But not sure how to manage the same problem for whole project, if install all 
headers in one patch, or add them gradually via separate patches by time ...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help