Thread (7 messages) 7 messages, 3 authors, 2021-03-24

Re: [dpdk-dev] [PATCH 1/2] eal: make max interrupt vector id configurable

From: David Marchand <hidden>
Date: 2021-03-24 11:15:17

On Wed, Mar 24, 2021 at 12:01 PM Jerin Jacob [off-list ref] wrote:
On Fri, Feb 26, 2021 at 12:31 AM [off-list ref] wrote:
quoted
From: Pavan Nikhilesh <redacted>

Make RTE_MAX_RXTX_INTR_VEC_ID configurable as MSI-X support a
maximum of 2048 vectors.
The default value is unchanged and set to 512.

IMO, We dont need to make it configurable and each platform sets its
value. That scheme won't work as generic distribution build will fail
to run.
Since PCIe specification defines this value and there is no
performance impact on increasing this,
IMO, We can change to 2048 as default.
It probably breaks rte_intr_* ABI.

struct rte_intr_handle {
...
        int efds[RTE_MAX_RXTX_INTR_VEC_ID];  /**< intr vectors/efds mapping */
        struct rte_epoll_event elist[RTE_MAX_RXTX_INTR_VEC_ID];
                                       /**< intr vector epoll event */
...


I see you need this for octeontx2, so wondering if you could handle
this differently in octeontx2 drivers?


-- 
David Marchand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help