Thread (81 messages) 81 messages, 7 authors, 2021-05-06

Re: [dpdk-dev] [PATCH v2 1/8] ether: refine debug compile option

From: Zhang, Qi Z <hidden>
Date: 2021-03-16 23:29:58

-----Original Message-----
From: Richardson, Bruce <redacted>
Sent: Tuesday, March 16, 2021 10:13 PM
To: Thomas Monjalon <redacted>
Cc: Zhang, Qi Z <redacted>; Andrew Rybchenko
[off-list ref]; Yigit, Ferruh [off-list ref];
dev@dpdk.org; Wang, Xiao W [off-list ref]; Wu, Jingjing
[off-list ref]; Xing, Beilei [off-list ref]; Guo, Jia
[off-list ref]; Yang, Qiming [off-list ref]; Wang, Haiyue
[off-list ref]
Subject: Re: [PATCH v2 1/8] ether: refine debug compile option

On Tue, Mar 16, 2021 at 02:39:05PM +0100, Thomas Monjalon wrote:
quoted
16/03/2021 14:05, Ferruh Yigit:
quoted
On 3/12/2021 12:12 PM, Qi Zhang wrote:
quoted
PMDs use RTE_LIBRTE_<PMD_NAME>_DEBUG_RX|TX as compile option
to
quoted
quoted
quoted
wrap data path debug code. As .config has been removed since the
meson build, It is not friendly for new DPDK users to notice those debug
options.
quoted
quoted
quoted
The patch introduces below compile options for specific Rx/Tx data
path debug, so PMD can choose to reuse them to avoid maintain their
own.
quoted
quoted
quoted
- RTE_LIBRTE_ETHDEV_DEBUG_RX
- RTE_LIBRTE_ETHDEV_DEBUG_TX

Also, all the compile options are documented on the overview page,
so users can easily find them.
English question: is "compile option" correct, or should it be
"compilation option"?
Cc Bruce to have a native in the discussion :)
"compilation options" is better.
However, throughout this patch, I wonder if "build" might be a better verb to
use than "compile".
OK, I will use "build" in v3, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help