Thread (6 messages) 6 messages, 3 authors, 2021-03-05

Re: [dpdk-dev] [PATCH v2] net/i40e: fix IPv4 fragment offload issue

From: Zhang, Qi Z <hidden>
Date: 2021-03-05 08:56:56

-----Original Message-----
From: dev <redacted> On Behalf Of Xing, Beilei
Sent: Tuesday, March 2, 2021 3:17 PM
To: Li, Xiaoyun <redacted>; Guo, Jia <redacted>; Lu,
Wenzhuo [off-list ref]
Cc: dev@dpdk.org; stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix IPv4 fragment offload issue


quoted
-----Original Message-----
From: Li, Xiaoyun <redacted>
Sent: Tuesday, March 2, 2021 3:03 PM
To: Xing, Beilei <redacted>; Guo, Jia
[off-list ref]; Lu, Wenzhuo [off-list ref]
Cc: dev@dpdk.org; Li, Xiaoyun <redacted>; stable@dpdk.org
Subject: [PATCH v2] net/i40e: fix IPv4 fragment offload issue

IPv4 fragment_offset mask was required to be 0 no matter what the spec
value was. But zero mask means not caring about fragment_offset field
then both non-frag and frag packets should hit the rule.

But the actual fragment rules should be like the following:
Only non-fragment packets can hit Rule 1:
Rule 1: mask=0x3fff, spec=0
Only fragment packets can hit rule 2:
Rule 2: mask=0x3fff, spec=0x8, last=0x2000

This patch allows the above rules.

Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR")
Cc: stable@dpdk.org

Signed-off-by: Xiaoyun Li <redacted>
Acked-by: Beilei Xing <redacted>
Applied to dpdk-next-net-intel.

Thanks
Qi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help