Thread (64 messages) 64 messages, 2 authors, 2021-03-04

Re: [dpdk-dev] [PATCH 09/13] net/hns3: fix maximum frame size update after buffer alloc

From: Ferruh Yigit <hidden>
Date: 2021-02-26 15:25:38

On 2/24/2021 1:28 AM, Lijun Ou wrote:
From: Chengchang Tang <tangchengchang@huawei.com>

After MTU changed, the buffer used to store packets in HW should be
reallocated. And buffer size is allocated based on the maximum frame
size in the PF struct. However, the value of maximum frame size  is
not updated in time when MTU is changed. This would lead to a packet
loss for not enough buffer.

This patch update the maximum frame size before reallocating the HW
buffer. And a rollback operation is added to avoid the side effects
of buffer reallocation failures.

Fixes: 1f5ca0b460cd ("net/hns3: support some device operations")
Fixes: d51867db65c1 ("net/hns3: add initialization")
Cc: stable@dpdk.org

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Lijun Ou <redacted>
Isn't the patch title should say 'before', like:
net/hns3: fix maximum frame size update _before_ buffer alloc

Or perhaps I get the patch wrong...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help