Thread (32 messages) flat view 32 messages, 5 authors, 2021-05-18

Re: [dpdk-dev] [PATCH v4] doc: add new tables for rte flow items and actions support

From: Thomas Monjalon <hidden>
Date: 2021-02-08 12:58:51

07/02/2021 11:52, Asaf Penso:
In http://doc.dpdk.org/guides/nics/overview.html, table 1.1 lists all
supported features.
It has a single line for "Flow API" that refers to rte_flow support.
rte_flow is composed of many items and actions that are not expressed in
this single line.
One comment to add to this commit message if you agree:
When the new rte_flow tables are filled for all relevant PMDs,
we could remove the row "Flow API" from the main table.
The following new tables are suggested:
1. rte_flow items
2. rte_flow actions
[...]
+vlan                 =
+ipv4                 =
+ipv6                 =
+icmp                 =
+udp                  =
+tcp                  =
+sctp                 =
+vxlan                =
[...]
+set_ipv4_src         =
+set_ipv4_dst         =
In items and actions above (and others) I understand the names are taken
directly from the enums or structs.
However I could imagine a slight different natural naming,
using some upper cases and spaces. Example:
	set_ipv4_dst -> set IPv4 dst
I see pros and cons. What are other opinions?

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help