Thread (20 messages) flat view 20 messages, 5 authors, 2021-04-08

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix UDP zero checksum error

From: Zhang, Qi Z <hidden>
Date: 2021-02-04 07:45:43

-----Original Message-----
From: David Marchand <redacted>
Sent: Wednesday, February 3, 2021 4:32 PM
To: Zhang, Qi Z <redacted>
Cc: Wang, Haiyue <redacted>; dev@dpdk.org;
pvalerio@redhat.com; aconole@redhat.com; Rong, Leyi
[off-list ref]; Tu, Lijuan [off-list ref];
Ruifeng.Wang@arm.com; Feifei.Wang2@arm.com; stable@dpdk.org; Guo, Jia
[off-list ref]; Richardson, Bruce [off-list ref];
Ananyev, Konstantin [off-list ref]
Subject: Re: [PATCH v2] net/ixgbe: fix UDP zero checksum error

On Wed, Feb 3, 2021 at 9:07 AM Zhang, Qi Z [off-list ref] wrote:
quoted
quoted
-----Original Message-----
From: Wang, Haiyue <redacted>
Sent: Wednesday, February 3, 2021 10:19 AM
To: dev@dpdk.org
Cc: pvalerio@redhat.com; aconole@redhat.com;
david.marchand@redhat.com; Zhang, Qi Z [off-list ref]; Rong,
Leyi [off-list ref]; Tu, Lijuan [off-list ref];
Ruifeng.Wang@arm.com; Feifei.Wang2@arm.com; Wang, Haiyue
[off-list ref]; stable@dpdk.org; Guo, Jia
[off-list ref]; Richardson, Bruce [off-list ref];
Ananyev, Konstantin [off-list ref]
Subject: [PATCH v2] net/ixgbe: fix UDP zero checksum error

There is an 82599 errata that UDP frames with a zero checksum are
incorrectly marked as checksum invalid by the hardware.  This was
leading to misleading PKT_RX_L4_CKSUM_BAD flag.

This patch changes the bad UDP checksum to
PKT_RX_L4_CKSUM_UNKNOWN,
quoted
quoted
so the software application will then have to recompute the checksum
itself if needed.

Bugzilla ID: 629

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org

Reported-by: Paolo Valerio <redacted>
Signed-off-by: Haiyue Wang <redacted>
Applied to dpdk-next-net-intel.
Why the rush for applying?
The ARM part is not done, Paolo said he would test the patch and I am pretty
sure a review can't hurt.


--
David Marchand
Oops, it should be a mistake, the patch has not been acked and reviewed yet.

Thanks for capture, will revert.
Qi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help