Thread (4 messages) flat view 4 messages, 4 authors, 2021-02-02

Re: [dpdk-dev] [PATCH v2] net/virtio: fix Virtio-PCI ops assignment

From: Ferruh Yigit <hidden>
Date: 2021-02-02 23:27:05

On 2/2/2021 10:03 AM, David Marchand wrote:
On Mon, Feb 1, 2021 at 9:33 PM Maxime Coquelin
[off-list ref] wrote:
quoted
VIRTIO_OPS() macro relies on the port ID stored in the
virtio_hw struct. Issue is that it is used before being
assigned at init time. It results in all devices setting
ops on port ID 0, causing crash later when calling ops
for port IDs other than 0.

This patch ensures port ID assignment is done at early
primary process probe time, before it is being used.

Bugzilla ID: 631
Fixes: 512e27eeb743 ("net/virtio: move PCI specific dev init to PCI ethdev init")

Reported-by: Wei Ling <redacted>
Signed-off-by: Maxime Coquelin <redacted>
Reviewed-by: David Marchand <redacted>

Tested-by: Wei Ling <redacted>
 >

Applied to dpdk-next-net/main, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help