Re: [dpdk-dev] [PATCH 14/14] net/hns3: support LSC event report

On 1/29/2021 1:49 AM, oulijun wrote:

在 2021/1/29 7:41, Ferruh Yigit 写道:

quoted

On 1/22/2021 10:18 AM, Lijun Ou wrote:

quoted

From: Chengwen Feng <redacted>

This patch support LSC(Link Status Change) event report.

There is a user config for lsc, 'dev->data->dev_conf.intr_conf.lsc', which 
seems not taken into account.

Frist of all, thank you for your review. Currently, the old firmware doest not 
support interrupt reporting. Therefore, the PF does not suport interrupt 
reporting through the mailbox. Therefore, the PF obtains interrupts in polling 
mode and then reports interrupts.

quoted

Also 'RTE_PCI_DRV_INTR_LSC' should be set in 'rte_pci_driver.drv_flags' to 
report this feature to higher levels.

In the future, the new firmware + PF will support interrupt reporting. In that 
case, the LSC capability of dev_flag will be set.
In the future, we will enable the VF to support LSC. That is, we are developing 
the PF to report LSC interrupts through the mailbox.

quoted

And when the feature is fully implemented, can you please add "Link status 
event" feature to 'hns3.ini'?

By then, we'll add it in hns3.ini.

Got it, so for now only LSC event report (even callbacks call) support added, I 
am proceeding with the patch.

quoted

quoted

Signed-off-by: Chengwen Feng <redacted>
Signed-off-by: Lijun Ou <redacted>

<...>
.