Thread (76 messages) 76 messages, 4 authors, 2021-02-11

Re: [dpdk-dev] [PATCH v7 08/12] net/octeontx_ep: added tx queue setup and release

From: Ferruh Yigit <hidden>
Date: 2021-01-29 14:04:33

On 1/29/2021 12:45 PM, Nalla Pradeep wrote:
Transmit queue setup involves allocating memory for the command queue
considering tx descriptor count and initializing data structure
representing the queue. Transmit queue release function frees the
command queue.

Signed-off-by: Nalla Pradeep <redacted>
<...>
+
+	otx_ep_info("IQ[%d]: base: %p basedma: %lx count: %d\n",
+		     iq_no, iq->base_addr, (unsigned long)iq->base_addr_dma,
'base_addr_dma' type is 'uint64_t', but isn't "unsigned long" 4 btyes in 32 bit?
Better to use PRIx64 for 'uint64_t' instead of '%lx', and using it removes the 
need to cast.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help