Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

29/01/2021 09:46, Ferruh Yigit:

On 1/29/2021 1:13 AM, oulijun wrote:

quoted

在 2021/1/28 22:12, Thomas Monjalon 写道:

quoted

28/01/2021 13:43, Lijun Ou:

quoted

The hns3 PMD add FEC features implementation in 20.11.
Therefore, need to update the hns3.ini for supporting.

Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC")
Cc: stable@dpdk.org

Signed-off-by: Lijun Ou <redacted>
---
  doc/guides/nics/features/hns3.ini | 1 +
  1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/hns3.ini 

b/doc/guides/nics/features/hns3.ini
index a467396..4ea568c 100644

--- a/doc/guides/nics/features/hns3.ini
+++ b/doc/guides/nics/features/hns3.ini

@@ -39,5 +39,6 @@ Stats per queue      = Y
  FW version           = Y
  Registers dump       = Y
  Multiprocess aware   = Y
+FEC             = Y

Please don't use tabs but only spaces in such .ini file.

OK， I will fix it

quoted

Can it be squashed with the commit adding the feature in default.ini?

Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advice.

Both OK to me, according Thomas' suggestion 1/5, 2/5 & 3/5 can be merged.

Yes please. All three patches have the same intent: add FEC to features doc.