Re: [dpdk-dev] [PATCH] net/i40e: fix X722 FDIR field mask

Hi Beilei,

Thanks for your review.

In theory, RSS does have the same issue, 
but in fact, there is no command to set the mask bit of these field when configuring RSS.

BR,
Alvin

-----Original Message-----
From: Xing, Beilei <redacted>
Sent: Friday, January 29, 2021 11:34 AM
To: Zhang, AlvinX <redacted>; Guo, Jia <redacted>;
Zhang, Qi Z [off-list ref]
Cc: dev@dpdk.org
Subject: RE: [PATCH] net/i40e: fix X722 FDIR field mask

quoted

-----Original Message-----
From: Zhang,Alvin <redacted>
Sent: Friday, January 29, 2021 10:09 AM
To: Guo, Jia <redacted>; Xing, Beilei
[off-list ref]; Zhang, Qi Z [off-list ref]
Cc: dev@dpdk.org
Subject: [PATCH] net/i40e: fix X722 FDIR field mask

From: Alvin Zhang <redacted>

The absolute field offsets of IPv4 or IPv6 header are related to
hardware configuration. The X710 and X722 have different hardware
configurations, and users can even modify the hardware configuration.
Therefore, The default values cannot be used when calculating mask offset.

commands and packets as below:
  flow create 0 ingress pattern eth / ipv4 proto is 255  / end
  actions queue index 2 / end
  pkt = Ether()/IP(ttl=63, proto=255)/Raw('X'*40)

  flow create 0 ingress pattern eth / ipv4 tos is 50 / udp / end
  actions queue index 2 / end
  pkt = Ether()/IP(tos=50)/UDP()/Raw('X'*40)

  flow create 0 ingress pattern eth / ipv6 tc is 12 / udp / end
  actions queue index 3 / end
  pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/UDP()/Raw('X'*40)

  flow create 0 ingress pattern eth / ipv6 hop is 34 / end actions
  queue index 3 / end
  pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/Raw('X'*40)

Not very clear about the issue, the above flows will fail to be created with X722?
And you fix is for FDIR, does RSS have similar issue?

Beilei