Re: [dpdk-dev] [PATCH 1/1] net/pcap: imissed stats support
From: Ferruh Yigit <hidden>
Date: 2021-01-28 18:21:08
On 1/25/2021 5:58 PM, Ido Goshen wrote:
Signed-off-by: Ido Goshen <redacted>
<...>
quoted hunk ↗ jump to hunk
@@ -695,6 +708,10 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->q_ibytes[i] = internal->rx_queue[i].rx_stat.bytes; rx_packets_total += stats->q_ipackets[i]; rx_bytes_total += stats->q_ibytes[i]; + unsigned long rx_missed = eth_stats_get_pcap_missed(dev, i); + if (rx_missed) + rx_missed_total = rx_missed - + internal->rx_queue[i].rx_stat.missed_reset;
'ps_drop' seems u_32 type, do you know how it behaves on overflow? Do you think do we need a check here for overflow?