[dpdk-dev] [PATCH] net/mlx5: fix 32-bit arch compilation issue
From: Alexander Kozyrev <hidden>
Date: 2021-01-28 17:10:37
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
There is a "cast to pointer from integer of different size"
compilation failure on 32-bit machines introduced by the
RTE_FLOW_ACTION_TYPE_MODIFY_FIELD implementation in mlx5 PMD.
Cast the specified value to be used as RTE_FLOW_FIELD_POINTER
to a pointer with an appropriate size suited for underlying arch.
Please squash this patch into the original commit if possible.
Fixes: 80ec1e84a4 ("net/mlx5: support modify field flow action")
Signed-off-by: Alexander Kozyrev <redacted>
---
drivers/net/mlx5/mlx5_flow_dv.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index ec9cee8f25..a151c62c3a 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c@@ -1749,7 +1749,9 @@ mlx5_flow_field_id_to_modify_info case RTE_FLOW_FIELD_POINTER: for (idx = 0; idx < MLX5_ACT_MAX_MOD_FIELDS; idx++) { if (mask[idx]) { - value[idx] = RTE_BE32(*(uint64_t *)data->value); + memcpy(&value[idx], + (void *)(uintptr_t)data->value, 32); + value[idx] = RTE_BE32(value[idx]); break; } }
@@ -1757,7 +1759,7 @@ mlx5_flow_field_id_to_modify_info case RTE_FLOW_FIELD_VALUE: for (idx = 0; idx < MLX5_ACT_MAX_MOD_FIELDS; idx++) { if (mask[idx]) { - value[idx] = RTE_BE32(data->value); + value[idx] = RTE_BE32((uint32_t)data->value); break; } }
--
2.24.1