Thread (6 messages) flat view 6 messages, 4 authors, 2021-01-27

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] ethdev: fix handling of close failure

From: Ferruh Yigit <hidden>
Date: 2021-01-27 11:44:54

On 1/25/2021 9:13 AM, Andrew Rybchenko wrote:
On 1/22/21 8:58 PM, Thomas Monjalon wrote:
quoted
If a failure happens when closing a port,
it was unnecessarily failing again in the function eth_err(),
because of a check against HW removal cause.
Indeed there is a big chance the port is released at this point.
Given the port is in the middle (or at the end) of a close process,
checking the error cause by accessing the port is a non-sense.
The error check is replaced by a simple return in the close function.

Bugzilla ID: 624
Fixes: 8a5a0aad5d3e ("ethdev: allow close function to return an error")
Cc: stable@dpdk.org

Reported-by: Anatoly Burakov <redacted>
Signed-off-by: Thomas Monjalon <redacted>
Acked-by: Andrew Rybchenko <redacted>
Applied to dpdk-next-net/main, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help