Thread (8 messages) flat view 8 messages, 2 authors, 2021-01-25

Re: [dpdk-dev] [PATCH 3/4] net/mlx5: fix secondary process attach port Tx queue

From: Raslan Darawsheh <hidden>
Date: 2021-01-25 08:31:06

Hi,
quoted hunk ↗ jump to hunk
-----Original Message-----
From: Suanming Mou <redacted>
Sent: Sunday, January 24, 2021 1:02 PM
To: Slava Ovsiienko <redacted>; Matan Azrad
[off-list ref]
Cc: Raslan Darawsheh <redacted>; dev@dpdk.org;
stable@dpdk.org
Subject: [PATCH 3/4] net/mlx5: fix secondary process attach port Tx queue

Currently, the secondary process port UAR register mapping used by Tx
queue is done during port initializing.

Unluckily, in port hot-plug case, the secondary process was requested
to initialize the port when primary process did not complete the
device configuration and the port Tx queue number is not configured
yet. Hence, the secondary process getS the zero Tx queue number during
probing, causing the UAR registers not be mapped in the correct
fashion.

This commit checks the configured number of Tx queues in secondary
process when the port start is requested. In case the Tx queue
number mismatch found the UAR mapping is reinitialized accordingly.

Fixes: 2aac5b5d119f ("net/mlx5: sync stop/start with secondary process")
cc: stable@dpdk.org

Signed-off-by: Suanming Mou <redacted>
Acked-by: Viacheslav Ovsiienko <redacted>
---
 drivers/net/mlx5/linux/mlx5_mp_os.c | 19 +++++++++++++++++++
 drivers/net/mlx5/mlx5.c             |  2 +-
 drivers/net/mlx5/mlx5.h             |  6 +++++-
 3 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/linux/mlx5_mp_os.c
b/drivers/net/mlx5/linux/mlx5_mp_os.c
index 08ade75..95372e2 100644
--- a/drivers/net/mlx5/linux/mlx5_mp_os.c
+++ b/drivers/net/mlx5/linux/mlx5_mp_os.c
[...]
-/* Per-process private structure. */
+/*
+ * Per-process private structure.
+ * Caution, secondary pocess may rebuid the struct during port start.
+ */
Typo in
pocess-> process
rebuid-> rebuild
will fix during integration.
[...]
1.8.3.1
Kindest regards
Raslan Darawsheh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help