Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers

On Wed, Jan 20, 2021 at 3:34 PM Bruce Richardson
[off-list ref] wrote:

On Fri, Jan 15, 2021 at 02:59:08PM +0000, Bruce Richardson wrote:

quoted

On Fri, Jan 15, 2021 at 02:55:41PM +0000, Bruce Richardson wrote:

quoted

On Fri, Jan 15, 2021 at 03:09:25PM +0100, Thomas Monjalon wrote:
I'm honestly fine either way on this (as with directory where
implementation lives) - main thing is to have the checking done, rather
than ignored.

And I (obviously) forgot to mention that the existing script is not currently
integrated into existing build or build-test scripts. I haven't looked into
how complex this would be, but it would require investigation time.

I do plan to look into re-using the script and other options around this
area - hopefully in RC2 timeframe. However, to make the patchset rework a
little easier, perhaps the small header fixes could be picked up for ahead
of any rework?

I'll merge those fixes hopefully tomorrow.


-- 
David Marchand