Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen

On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote:

This is now the right timeframe to introduce this change
with the new Python module dependency.
Unfortunately, the ABI check is returning an issue:

'const char mlx5_common_pci_pmd_info[62]' was changed
to 'const char mlx5_common_pci_pmd_info[60]' at rte_common_mlx5.pmd.c

Will investigate and fix ASAP.
 

Few more comments below:

20/10/2020 19:44, Dmitry Kozlyuk:

quoted

--- a/buildtools/meson.build
+++ b/buildtools/meson.build
+if host_machine.system() != 'windows'  

You can use "is_windows".

It's defined by config/meson.build, which is processed after
buidtools/meson.build, because of the dependency, if swapped:

	config/x86/meson.build:6:1: ERROR: Unknown variable
	"binutils_avx512_check".

quoted

--- a/doc/guides/linux_gsg/sys_reqs.rst
+++ b/doc/guides/linux_gsg/sys_reqs.rst
+*   ``pyelftools`` (version 0.22+)  

This requirement is missing in doc/guides/freebsd_gsg/build_dpdk.rst

OK.

quoted

--- a/meson.build
+++ b/meson.build
-subdir('buildtools/pmdinfogen')  

This could be in patch 3 (removing the code).

It would redefine "pmdinfogen" variable to old pmdinfogen.
Besides, why build what's not used at this patch already?