On Tue, Jan 12, 2021 at 11:25 AM Rasesh Mody [off-list ref] wrote:

quoted

From: Jerin Jacob <redacted>
Sent: Tuesday, January 12, 2021 10:21 AM

On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody [off-list ref] wrote:

quoted

quoted

From: dev <redacted> On Behalf Of Igor Russkikh
Sent: Monday, January 4, 2021 6:15 PM

quoted

When calling rte_eth_promiscuous_enable(port_id) followed by
rte_eth_allmulticast_enable(port_id), the port is not in promisc
mode anymore. This patch ensures that promisc mode takes
precedence over allmulticast mode fixing the regression introduced by

b10231aed1ed.

Please add Fixes:

quoted

quoted

quoted

Signed-off-by: Balazs Nemeth <redacted>

Even if promiscuous mode is disabled after the change, allmulti mode setting will persist.
Fix looks good to me.

Acked-by: Rasesh Mody <rmody@marvell.com>

Fixed check-git-log.sh issues and applied to dpdk-next-net-mrvl/for-main. Thanks

Thanks,
Rasesh

quoted

quoted

quoted

Igor