Re: [dpdk-dev] [PATCH] net/octeontx2: fix corruption in segments list
From: Jerin Jacob <hidden>
Date: 2021-01-12 18:14:04
From: Jerin Jacob <hidden>
Date: 2021-01-12 18:14:04
On Mon, Dec 28, 2020 at 5:48 PM Nithin Dabilpuram [off-list ref] wrote:
On Mon, Dec 21, 2020 at 07:33:08PM +0530, skori@marvell.com wrote:quoted
From: Sunil Kumar Kori <redacted> On Tx, lastseg->next is not being reset to null for multi segmented packet and same mbuf can be used on Rx which has a stale mbuf entry into mbuf->next. On Rx, application receives mbuf with mbuf->next uninitialized though mbuf->nb_segs is correct. Application iterates over all segments using mbuf->next ignoring mbuf->nb_segs which leads to undefined behavior. So earlier assumption of just having right value in mbuf->nb_segs is enough, is incorrect. Mbuf must contain valid and synced value in nb_segs and next pointer. Fixes: 364eb0e46683 ("net/octeontx2: avoid per packet barrier with multi segment") Cc: stable@dpdk.org Signed-off-by: Sunil Kumar Kori <redacted>
quoted
Acked-by: Nithin Dabilpuram <redacted>
Applied to dpdk-next-net-mrvl/for-main. Thanks