Re: [dpdk-dev] [PATCH v3] drivers/common: enable Windows common mlx5 compilation
From: Thomas Monjalon <hidden>
Date: 2021-01-11 20:52:58
03/01/2021 09:00, Tal Shnaiderman:
quoted hunk ↗ jump to hunk
From: Ophir Munk <redacted> Prior to this commit meson did not progress beyond directory drivers/common for Windows compilations. This commit enables drivers compilation under this directory. Signed-off-by: Ophir Munk <redacted> Signed-off-by: Tal Shnaiderman <redacted> Acked-by: Matan Azrad <redacted> ------ a/drivers/common/meson.build +++ b/drivers/common/meson.build@@ -1,10 +1,8 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Cavium, Inc -if is_windows - subdir_done() +if not is_windows + std_deps = ['eal'] + drivers = ['cpt', 'dpaax', 'iavf', 'mvep', 'octeontx', 'octeontx2', 'sfc_efx'] endif - -std_deps = ['eal'] -drivers = ['cpt', 'dpaax', 'iavf', 'mvep', 'octeontx', 'octeontx2', 'sfc_efx']
The change in drivers/common/meson.build is useless. common/mlx5 is called directly from drivers/meson.build And when one of these drivers will support Windows, the Windows check will have to move in drivers file.