On 1/6/2021 11:58 AM, Jerin Jacob wrote:

On Wed, Jan 6, 2021 at 5:06 PM Pradeep Kumar Nalla [off-list ref] wrote:

quoted

-----Original Message-----
From: Ferruh Yigit <redacted>
Sent: Tuesday, January 5, 2021 8:59 PM
To: Pradeep Kumar Nalla <redacted>
Cc: Jerin Jacob Kollanukkaran <redacted>; Satananda Burla <sburla@marvell.com>; dev@dpdk.org
Subject: Re: [EXT] Re: [dpdk-dev] [PATCH 00/15] Octeon Tx/Tx2 Endpoint pmd

On 1/5/2021 2:43 PM, Pradeep Kumar Nalla wrote:

Please do not top post, reply moved below.

quoted

Thanks
Pradeep.
-----Original Message-----
From: Ferruh Yigit <redacted>
Sent: Monday, January 4, 2021 5:22 PM
To: Pradeep Kumar Nalla <redacted>
Cc: Jerin Jacob Kollanukkaran <redacted>; Satananda Burla
[off-list ref]; dev@dpdk.org
Subject: [EXT] Re: [dpdk-dev] [PATCH 00/15] Octeon Tx/Tx2 Endpoint pmd

External Email

----------------------------------------------------------------------
On 12/31/2020 7:22 AM, Nalla, Pradeep wrote:

quoted

From: "Nalla Pradeep" <redacted>

This patch set contains PMD with minimal set of operations that can
drive both Octeon Tx and Tx2 in endpoint.

Hi Pradeep,

There is already octeontx and octeontx2 net drivers, what is the difference of the 'endpoint' driver, why it is needed, can you please give more information?

Hi Ferruh

This PMD, while running on a host, drives octeontx/octeontx2 over pci bus, where as "OcteonTx and OcteonTx2 net drivers" run on respective Tx/Tx2 SOCs to make use of h/w blocks present on the SOC.

But aren't they same HW block, either in the SoC or external ethernet controller via PCI bus?

No, this pmd doesn't access any h/w block on the soc. When in ep mode octeontx and octeontx2 present themselves as network devices and this pmd will program that interface and does packet rx/tx.

quoted

As far as I can see octeontx2 access the device via PCI bus, why updating the existing driver and adding new device IDs is not working?

OxteonTx2 access H/W blocks on soc which also appear as PCI devices.

In other words,
- The net/octeontx2 driver has a separate set of HW devices that are
not accessible from x86 host.

So is the net/octeontx2 superset of the endpoint driver?

- Even though net/octeontx2 is based on PCI bus, scope of that PCI bus
is internal to SoC. It is an internal bus emulated as PCI to help
standard device probing works.

This shouldn't differ from driver perspective, right, for driver it is 
configuring device on PCI bus.

Just to be able to eliminate any code that can be eliminated, what prevents 
using 'net/octeontx2'?
Like I assume one of the HW block not accessible for EP device is eventdev 
block, is this making required driver change too big, or is it completely 
something else?

Btw, I can see some end point device PCI IDs are already used, 
PCI_DEVID_OCTEONTX2_EP_VF, but it is used by a rawdev driver (raw/octeontx2_ep), 
not sure what it is.