Thread (13 messages) 13 messages, 4 authors, 2021-01-05

Re: [dpdk-dev] [PATCH v3] net/i40e: issue with ADD VLAN from Guest

From: Ferruh Yigit <hidden>
Date: 2021-01-04 16:42:52

On 12/16/2020 2:09 AM, Guo, Jia wrote:
Acked-by: Jeff Guo <jia.guo@intel.com<mailto:jia.guo@intel.com>>

From: Souvik Dey <redacted>
Sent: Tuesday, December 15, 2020 9:28 PM
To: Xing, Beilei <redacted>; Guo, Jia <redacted>; Zhang, Qi Z <redacted>
Cc: dev@dpdk.org; Souvik Dey <redacted>
Subject: [PATCH v3] net/i40e: issue with ADD VLAN from Guest

Reset the configuration of vlan strip that would be change
by the pf kernel driver when adding vlan from vf.
Application cannot use rte_eth_dev_set_vlan_offload() to set
the VLAN_STRIP, as this will only work for the first time when
original and current config mismatch, but for all subsequent call
it will be ignored.

Signed-off-by: Souvik Dey <sodey@rbbn.com<mailto:sodey@rbbn.com>>
I suggest title: "net/i40e: fix VLAN stripping in VF"
Will update the title and some wording in the commit log while merging.

And I assume this should be backported, so will add stable@dpdk.org tag,
but can you please confirm the Linux PF behavior was always same?

And if the Linux PF behavior was always same, should we add the DPDK commit as 
fixes commit, @Qi, @Jeff, what do you think?

Other question is, does Linux PF and DPDK PF behave differently on enabling VLAN 
stripping and should it be unified to be consistent?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help