Re: [dpdk-dev] [PATCH v2 4/8] emu/iavf: add vfio-user device register and unregister
From: Wu, Jingjing <hidden>
Date: 2021-01-04 06:45:17
From: Wu, Jingjing <hidden>
Date: 2021-01-04 06:45:17
+static inline struct iavf_emu_sock_list * iavf_emu_find_sock_list(char
+*sock_addr) {
+ struct iavf_emu_sock_list *list;
+ struct iavf_emudev *dev;
+ int list_exist;Initialize list_exist to 0?
+
+ if (!sock_addr)
+ return NULL;
+
+ pthread_mutex_lock(&sock_list_lock);
+
+ TAILQ_FOREACH(list, &sock_list, next) {
+ dev = (struct iavf_emudev *)list->emu_dev->priv_data;
+
+ if (!strcmp(dev->sock_addr, sock_addr)) {
+ list_exist = 1;
+ break;
+ }
+ break;This "break" need to be removed.
+ } + + pthread_mutex_unlock(&sock_list_lock); + + if (!list_exist) + return NULL; + + return list; +} +