Re: [dpdk-dev] [PATCH] examples/fips_validation: fix resource leak on failure
From: David Marchand <hidden>
Date: 2020-10-30 13:09:21
On Wed, Oct 28, 2020 at 4:53 PM Ciara Power [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The dst variable went out of scope on failure in the get_writeback_data function. This is now freed before returning -1. Coverity issue: 363453 Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list") Cc: roy.fan.zhang@intel.com Signed-off-by: Ciara Power <redacted> --- examples/fips_validation/main.c | 1 + 1 file changed, 1 insertion(+)diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 07532c9562..be38eb29b6 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c@@ -1128,6 +1128,7 @@ get_writeback_data(struct fips_val *val) if (data_len) { RTE_LOG(ERR, USER1, "Error -1: write back data\n"); + free(dst);
Hum should we instead free the pointer to the allocated buffer, i.e. wb_data, rather than dst that got potentially incremented? -- David Marchand