Re: [dpdk-dev] [PATCH] examples/fips_validation: fix checking return value
From: David Marchand <hidden>
Date: 2020-10-30 13:01:43
On Wed, Oct 28, 2020 at 4:38 PM Ciara Power [off-list ref] wrote:
The return value was not being checked when calling the
get_writeback_data function in the AES test case. On failure, this led
to a NULL dereference when using memcpy later. The return value is now
checked to avoid this NULL dereference.
Coverity issue: 363463
Fixes: cd255ccf5764 ("examples/fips_validation: support AES parsing")
I'd rather flag:
Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list")
Can you double check?
quoted hunk ↗ jump to hunk
Cc: marko.kovacevic@intel.com Cc: roy.fan.zhang@intel.com Cc: stable@dpdk.org Signed-off-by: Ciara Power <redacted> --- examples/fips_validation/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 07532c9562..bc7abd2b8f 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c@@ -1520,7 +1520,9 @@ fips_mct_aes_test(void) return ret; } - get_writeback_data(&val); + ret = get_writeback_data(&val); + if (ret < 0) + return ret; if (info.op == FIPS_TEST_DEC_AUTH_VERIF) memcpy(prev_in, vec.ct.val, AES_BLOCK_SIZE);
And I think we have the same issue in fips_mct_sha_test(). -- David Marchand