Thread (21 messages) 21 messages, 3 authors, 2020-09-30

Re: [dpdk-dev] [PATCH v2 5/6] ethdev: fix mis-named parameter

From: Bruce Richardson <hidden>
Date: 2020-09-30 09:01:35

On Tue, Sep 29, 2020 at 07:34:17PM +0200, Thomas Monjalon wrote:
quoted
The parameter to rte_eth_link_speed_to_str was called "speed_link" in
the function prototype in the header file, but "link_speed" everywhere
else.  This showed up as warnings when building the API docs, due to
missing and undocumented parameters from doxygen's viewpoint.

Rename the prototype value to the correct name to fix these issues.
It has been fixed by David and merged already by Ferruh.
Yep, I guessed there was a patch outstanding for it from someone, though I
think the patch wasn't merged when I did this patch, so I included it to
guarantee that this patchset didn't break the build when werror was turned
on.

/Bruce
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help