Re: [dpdk-dev] [PATCH V7 1/3] ethdev: introduce FEC API
From: Andrew Rybchenko <hidden>
Date: 2020-09-19 08:45:16
On 9/18/20 9:10 PM, Ajit Khaparde wrote:
On Fri, Sep 18, 2020 at 5:13 AM Ananyev, Konstantin [off-list ref] wrote:quoted
quoted
This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) <redacted> Reviewed-by: Wei Hu (Xavier) <redacted> Reviewed-by: Chengwen Feng <redacted> Reviewed-by: Chengchang Tang <tangchengchang@huawei.com> --- v6->v7: deleted RTE_ETH_FEC_NUM to prevent ABI breakage. add new macro to indicate translation from fec mode to capa. --- v5->v6: modified release notes. deleted check duplicated for FEC API fixed code styles according to DPDK coding style. added _eth prefix. --- v4->v5: Modifies FEC capa definitions using macros. Add RTE_ prefix for public FEC mode enum. add release notes about FEC for dpdk20_11. --- v2->v3: add function return value "-ENOTSUP" for API ---Acked-by: Konstantin Ananyev <redacted>Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
I'm sorry, but I'm still unhappy with enum members order and get capabilities API. See v5 notes.