Re: [dpdk-dev] [PATCH v3 2/6] test/ring: fix wrong parameter passed to the enqueue APIs
From: Honnappa Nagarahalli <hidden>
Date: 2020-09-14 04:28:24
<snip>
When enqueue one element to ring in the performance test, a pointer should
be passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table of
void *pointers.
Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests")
Cc: honnappa.nagarahalli@arm.com
Cc: stable@dpdk.org
Signed-off-by: Feifei Wang <redacted>
Reviewed-by: Ruifeng Wang <redacted>
Reviewed-by: Phil Yang <redacted>Reviewed-by: Honnappa Nagarahalli <redacted>
quoted hunk ↗ jump to hunk
--- app/test/test_ring.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/app/test/test_ring.h b/app/test/test_ring.h indexaa6ae67ca..d4b15af7c 100644--- a/app/test/test_ring.h +++ b/app/test/test_ring.h@@ -50,11 +50,11 @@ test_ring_enqueue(struct rte_ring *r, void **obj, intesize, unsigned int n, if ((esize) == -1) switch (api_type) { case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE): - return rte_ring_enqueue(r, obj); + return rte_ring_enqueue(r, *obj); case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_SINGLE): - return rte_ring_sp_enqueue(r, obj); + return rte_ring_sp_enqueue(r, *obj); case (TEST_RING_THREAD_MPMC | TEST_RING_ELEM_SINGLE): - return rte_ring_mp_enqueue(r, obj); + return rte_ring_mp_enqueue(r, *obj); case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_BULK): return rte_ring_enqueue_bulk(r, obj, n, NULL); case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_BULK): -- 2.17.1