Re: [dpdk-dev] [PATCH 4/7] ethdev: mark internal functions
From: Andrew Rybchenko <hidden>
Date: 2020-08-29 12:08:09
On 8/24/20 12:40 PM, Ferruh Yigit wrote:
Some ethdev functions are for drivers only, not for applications. Since we have '__rte_internal' tag available now, marking internal functions with it and moving functions to INTERNAL section in linker script. This is also good for documenting the internal functions. Some internal APIs seems marked as experimental, but it doesn't make sense to have internals APIs as experimental, updating their tag and doxygen comments. Signed-off-by: Ferruh Yigit <redacted>
Acked-by: Andrew Rybchenko <redacted> with a nit below [snip]
quoted hunk ↗ jump to hunk
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 2ce186610b..ce2e0ec0e4 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h@@ -1723,8 +1723,7 @@ rte_eth_find_next_of(uint16_t port_id_start, */ __rte_experimental uint16_t -rte_eth_find_next_sibling(uint16_t port_id_start, - uint16_t ref_port_id); +rte_eth_find_next_sibling(uint16_t port_id_start, uint16_t ref_port_id);
Looks unrelated [snip]