-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net]
Sent: Thursday, August 6, 2020 9:20 PM
To: wangyunjian <redacted>
Cc: dev@dpdk.org; stable@dpdk.org; keith.wiles@intel.com;
ophirmu@mellanox.com; Lilijun (Jerry) [off-list ref]; xudingke
[off-list ref]; stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/tap: free mempool when
closing

06/08/2020 14:47, wangyunjian:

quoted

From: Thomas Monjalon [mailto:thomas@monjalon.net]

quoted

29/07/2020 13:35, wangyunjian:

quoted

From: Yunjian Wang <redacted>

When setup tx queues, we will create a mempool for the 'gso_ctx'.
The mempool is not freed when closing tap device. If free the tap
device and create it with different name, it will create a new
mempool. This maybe cause an OOM.

While at it, please look at implementing RTE_ETH_DEV_CLOSE_REMOVE
behaviour in tap. Thanks

I read the codes about tap device. Currently, the tap pmd doesn't use
RTE_ETH_DEV_CLOSE_REMOVE flag.

I know. That's why I suggest to switch to RTE_ETH_DEV_CLOSE_REMOVE.
Please see this deprecation notice:
	http://git.dpdk.org/dpdk/commit/?id=7efbaa7b4e423

OK, I have sent a patch to add this feature for tap device.

https://patchwork.dpdk.org/patch/76137/

Thanks,
Yunjian