Re: [dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging
From: Jerin Jacob <hidden>
Date: 2020-08-11 18:28:05
Possibly related (same subject, not in this thread)
- 2020-06-27 · [dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging · Tim McDaniel <hidden>
- 2020-06-12 · [dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging · McDaniel, Timothy <hidden>
On Fri, Jul 31, 2020 at 1:24 AM McDaniel, Timothy [off-list ref] wrote:
From: "McDaniel, Timothy" <redacted>
Please avoid empty comments.
quoted hunk ↗ jump to hunk
Signed-off-by: McDaniel, Timothy <redacted> --- drivers/event/dlb/dlb_log.h | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 drivers/event/dlb/dlb_log.hdiff --git a/drivers/event/dlb/dlb_log.h b/drivers/event/dlb/dlb_log.h new file mode 100644 index 0000000..c69c9e5 --- /dev/null +++ b/drivers/event/dlb/dlb_log.h@@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2016-2020 Intel Corporation + */ + +#ifndef _DLB_EVDEV_LOG_H_ +#define _DLB_EVDEV_LOG_H_ + +extern int eventdev_dlb_log_level;
RTE_LOG_REGISTER is missing. Use real dynamic logging.
+ +/* Dynamic logging */ +#define DLB_LOG_IMPL(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, eventdev_dlb_log_level, "%s" fmt "\n", \ + __func__, ##args) + +#define DLB_LOG_INFO(fmt, args...) \ + DLB_LOG_IMPL(INFO, fmt, ## args) + +#define DLB_LOG_ERR(fmt, args...) \ + DLB_LOG_IMPL(ERR, fmt, ## args) + +/* remove debug logs at compile time unless actually debugging */ +#define DLB_LOG_DBG(fmt, args...) \ + RTE_LOG_DP(DEBUG, PMD, fmt, ## args) + +#endif /* _DLB_EVDEV_LOG_H_ */ -- 1.7.10