Thread (19 messages) 19 messages, 4 authors, 2020-09-02

Re: [dpdk-dev] [PATCH v2 4/4] net/bnxt: fix vfrep add when VF interface is down

From: Thomas Monjalon <hidden>
Date: 2020-08-05 20:37:08

31/07/2020 19:23, Ajit Khaparde:
From: Venkat Duvvuru <redacted>

While adding vfrep port to OVS bridge, vnic & svif information of
You should avoid justifying use cases with external applications.
vfrep's endpoint(VF) would be needed to program default flow rules.
vfrep is not a well known word. Please use "VF representor".
However, if the endpoint interface is down when vfrep port is added,
firmware will return invalid vnic & svif information.

This patch fixes the problem by registering to DEFAULT_VNIC_CHANGE
async event and once the async event is received, use the endpoint
information(VF's fid) to fetch it's vnic & svif information and
program the default flow rules.

Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")
It looks to be a patch adding the support of a special case:
configuring VF representor while VF is down.
I don't think it is a fix.

Signed-off-by: Venkat Duvvuru <redacted>
Reviewed-by: Somnath Kotur <redacted>
---
 drivers/net/bnxt/bnxt.h        | 21 ++++++++++
 drivers/net/bnxt/bnxt_cpr.c    | 51 +++++++++++++++++++++++++
 drivers/net/bnxt/bnxt_ethdev.c | 12 +++++-
 drivers/net/bnxt/bnxt_hwrm.c   |  4 ++
 drivers/net/bnxt/bnxt_hwrm.h   |  2 +
 drivers/net/bnxt/bnxt_reps.c   | 70 +++++++++++++++++++++++++---------
 6 files changed, 140 insertions(+), 20 deletions(-)
This is quite a big change.

This patchset has been deferred (not pulled in next-net) in -rc3.
I confirm it is postponed to DPDK 20.11.

In general, the idea is to have limits to avoid last minute rushes.
Thanks for understanding.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help