Re: [dpdk-dev] [PATCH v4 4/5] telemetry: implement empty stubs for Windows
From: Thomas Monjalon <hidden>
Date: 2020-08-05 08:27:38
05/08/2020 01:39, Dmitry Kozlyuk:
On Tue, 4 Aug 2020 09:29:46 +0300, Fady Bader wrote:quoted
Telemetry didn't compile under Windows. Empty stubs implementation was added for Windows. Signed-off-by: Fady Bader <redacted> --- lib/librte_telemetry/rte_telemetry.h | 4 +++ lib/librte_telemetry/telemetry.c | 51 ++++++++++++++++++++++++++++++++- lib/librte_telemetry/telemetry_legacy.c | 26 ++++++++++++++++- 3 files changed, 79 insertions(+), 2 deletions(-)You could #ifdef code in librte_ethdev that uses librte_telemetry and not build librte_telemetry at all. This approach is already taken in eal_common_options.c and it avoids spreading #ifdef throughout telemetry code.
The problem is that telemetry can be used anywhere, not only in ethdev. I feel it is better to #ifdef telemetry than every telemetry calls.