Re: [dpdk-dev] [PATCH v4 4/9] eal: introduce thread uninit helper
From: Jerin Jacob <hidden>
Date: 2020-06-26 15:00:34
On Fri, Jun 26, 2020 at 8:18 PM David Marchand [off-list ref] wrote:
This is a preparation step for dynamically unregistering threads. Since we explicitly allocate a per thread trace buffer in rte_thread_init, add an internal helper to free this buffer. Signed-off-by: David Marchand <redacted> --- Note: I preferred renaming the current internal function to free all threads trace buffers (new name trace_mem_free()) and reuse the previous name (trace_mem_per_thread_free()) when freeing this buffer for a given thread. Changes since v2: - added missing stub for windows tracing support, - moved free symbol to exported (experimental) ABI as a counterpart of the alloc symbol we already had, Changes since v1: - rebased on master, removed Windows workaround wrt traces support,
+/** + * Uninitialize per-lcore info for current thread. + */ +void rte_thread_uninit(void); +
Is it a public API? I guess not as it not adding in .map file. If it is private API, Is n't it better to change as eal_thread_ like another private API in eal_thread.h?