On 6/11/2020 9:14 AM, Thomas Monjalon wrote:

29/05/2020 01:14, Pallavi Kadam:

quoted

Fixed bunch of warnings when compiling using clang on Windows
such as the use of an unsafe string function (strerror),
[-Wunused-variable], [-Wunused-function] in eal_common_options.c
[-Wunused-const-variable] in getopt.c and [-Wunused-parameter]
in eal_common_thread.c.
Also fixed warnings generated using Mingw:
[-Werror=old-style-definition], [-Werror=cast-function-type] and
[-Werror=attributes]

Signed-off-by: Ranjit Menon <redacted>
Signed-off-by: Pallavi Kadam <redacted>
Tested-by: Pallavi Kadam <redacted>

Tested-by is useless if you are the author of the patch.

Sorry for this, will remove the tag in v4.

quoted

  lib/librte_eal/common/eal_common_options.c | 8 +++++++-
  lib/librte_eal/windows/eal.c               | 2 +-
  lib/librte_eal/windows/eal_lcore.c         | 2 +-
  lib/librte_eal/windows/eal_thread.c        | 3 ++-
  lib/librte_eal/windows/getopt.c            | 4 ++--
  lib/librte_eal/windows/include/pthread.h   | 6 ++++--
  6 files changed, 17 insertions(+), 8 deletions(-)

There were some changes since v2 which were not reviewed.
Someone please?