Thread (10 messages) 10 messages, 4 authors, 2020-06-01

Re: [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows

From: Dmitry Kozlyuk <hidden>
Date: 2020-06-01 01:54:42

On Sun, 31 May 2020 16:02:21 +0300
Andrew Rybchenko [off-list ref] wrote:

[snip]
quoted
 
+#ifndef RTE_EXEC_ENV_WINDOWS
 #include <rte_trace_point_register.h>
+#endif  
I really dislike the approach. It adds too many conditional
compilation statements which make code harder to read.

You can have dummy implementation of these functions on
Windows to avoid the conditional compilation.
Memory management series, on which this patchset depends, does have such
wrappers: http://patchwork.dpdk.org/patch/70565/.

-- 
Dmitry Kozlyuk
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help