Re: [dpdk-dev] [EXTERNAL] [PATCH 2/6] net/bnxt: fix potential data race
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2020-03-03 18:16:21
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2020-03-03 18:16:21
On Tue, 3 Mar 2020 18:13:22 +0000 Christopher Ertl [off-list ref] wrote:
Can we add the `volatile` qualifier to the `hwrm_cmd_resp_addr` member (in drivers/net/bnxt/bnxt.h) to get a stronger guarantee that the compiler won't insert TOCTOU races in the output? Christopher Ertl | MSRC Vulnerabilities & Mitigations | Microsoft Limited | +44 7773976589 | Christopher.Ertl@microsoft.com Microsoft Limited (company number 01624297) is a company registered in England and Wales whose registered office is at Microsoft Campus, Thames Valley Park, Reading. RG6 1WG
Should this be done for all the registers in that structure?