Re: [dpdk-dev] [PATCH v1 1/2] net/axgbe: add additional MAC address support
From: Namburu, Chandu-babu <hidden>
Date: 2020-02-28 14:15:53
[AMD Official Use Only - Internal Distribution Only] Hi Ferruh, Thank you for pointing it out, I will correct them. Regards, Chandu -----Original Message----- From: Ferruh Yigit <redacted> Sent: Friday, February 28, 2020 7:33 PM To: Namburu, Chandu-babu <redacted>; dev@dpdk.org; Somalapuram, Amaranath <redacted> Cc: Kumar, Ravi1 <redacted> Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/axgbe: add additional MAC address support On 2/28/2020 1:59 PM, chandu@amd.com wrote:
From: Chandu Babu N <redacted> Supports adding MAC addresses to enable whitelist filtering to accept packets implement eth_dev_ops mac_addr_set, mac_addr_add, mac_addr_remove and set_mc_addr_list Signed-off-by: Chandu Babu N <redacted>
Hi Chandu, Amaranath, Same comment with previous patchset, Please check the "Contributing Code to DPDK" before sending patch: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdoc.dpdk.org%2Fguides%2Fcontributing%2Fpatches.html&data=02%7C01%7Cchandu%40amd.com%7Cdaf59805e48d4384dc8708d7bc570ff4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637184954444477587&sdata=PLWzmriaCP0%2FS51xJomCQWlT7EJ5bwz95ZOsJAP5fX0%3D&reserved=0 And prefer threading for series instead of sending them one by one, as noted in above document: ''Shallow threading (--thread --no-chain-reply-to) is preferred for a patch series.''