Thread (104 messages) 104 messages, 19 authors, 2020-03-17

Re: [dpdk-dev] [PATCH v3 4/4] add ABI checks

From: David Marchand <hidden>
Date: 2020-02-01 15:30:32

On Thu, Jan 30, 2020 at 11:33 PM Thomas Monjalon [off-list ref] wrote:
30/01/2020 17:00, David Marchand:
quoted
Enabling them requires a configuration that will trigger the ABI dumps
generation as part of the existing devtools/test-build.sh and
devtools/test-meson-builds.sh scripts.
[...]
quoted
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
      if [ -f "$builddir/build.ninja" ] ; then
+             # for existing environments, force debugoptimized so that ABI
+             # checks can run
+             $MESON configure --buildtype=debugoptimized $builddir
This is forcing meson to re-run each time, even if the buildtype is
already "debugoptimized".
Please query meson configuration to avoid useless re-run:

        $MESON configure $builddir | awk '$1=="buildtype" {print $2}'
Good catch, will fix.


-- 
David Marchand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help