Hi Akhil,

Please see inline.

Thanks,
Anoob

-----Original Message-----
From: Akhil Goyal <redacted>
Sent: Friday, January 31, 2020 7:06 PM
To: Anoob Joseph <redacted>; Declan Doherty
[off-list ref]; Thomas Monjalon [off-list ref]
Cc: Ankur Dwivedi <redacted>; Jerin Jacob Kollanukkaran
[off-list ref]; Narayana Prasad Raju Athreya
[off-list ref]; Kiran Kumar Kokkilagadda
[off-list ref]; Nithin Kumar Dabilpuram
[off-list ref]; Pavan Nikhilesh Bhagavatula
[off-list ref]; Archana Muniganti [off-list ref];
Tejasree Kondoj [off-list ref]; Vamsi Krishna Attunuru
[off-list ref]; Lukas Bartosik [off-list ref];
dev@dpdk.org
Subject: [EXT] RE: [PATCH v3 14/15] net/octeontx2: add inline Tx path changes

External Email

----------------------------------------------------------------------
Hi Anoob,

quoted

From: Ankur Dwivedi <redacted>

Adding pre-processing required for inline IPsec outbound packets.

Signed-off-by: Ankur Dwivedi <redacted>
Signed-off-by: Anoob Joseph <redacted>
Signed-off-by: Archana Muniganti <redacted>
Signed-off-by: Tejasree Kondoj <redacted>
Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
---
 drivers/event/octeontx2/meson.build        |   3 +-
 drivers/event/octeontx2/otx2_worker.h      |   6 +
 drivers/net/octeontx2/otx2_ethdev_sec.c    |  82 +++++++++++++
 drivers/net/octeontx2/otx2_ethdev_sec.h    |  19 +++
 drivers/net/octeontx2/otx2_ethdev_sec_tx.h | 181
+++++++++++++++++++++++++++++
 5 files changed, 290 insertions(+), 1 deletion(-)  create mode 100644
drivers/net/octeontx2/otx2_ethdev_sec_tx.h

diff --git a/drivers/event/octeontx2/meson.build

b/drivers/event/octeontx2/meson.build
index 56febb8..be4b47a 100644

--- a/drivers/event/octeontx2/meson.build
+++ b/drivers/event/octeontx2/meson.build

@@ -31,6 +31,7 @@ foreach flag: extra_flags
 	endif
 endforeach

-deps += ['bus_pci', 'common_octeontx2', 'mempool_octeontx2',

'pmd_octeontx2']
+deps += ['bus_pci', 'common_octeontx2', 'cryptodev',
+'mempool_octeontx2',
'pmd_octeontx2',
+         'security']

 includes += include_directories('../../crypto/octeontx2')

Why would you need cryptodev in event driver meson.build?
If you really need it, then why only in meson.build, Makefile should also have
some change.

[Anoob] On our platform, it's the eventdev which does packet I/O during inline processing. So the Tx and Rx paths are embedded into event_dequeue_burst() and tx_adapter_enqueue(). Hence the need for such dependency.

I'll have the meson and Makefiles synced. Can send the updated series once you are done with the rest of the reviews. The dependency was added in meson.build file when some build failure was observed.

Please make sure that all individual patches compile for both meson and
Makefile.
I have not run the test yet. Will run it on Monday.

[Anoob] Sure. From our end, we have all the patches passing the build stages. In case if there is any failure, I'll have it addressed with the next version.
 

Regards,
Akhil