Thread (25 messages) 25 messages, 7 authors, 2020-02-16

Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is disabled

From: Rao, Nikhil <hidden>
Date: 2020-01-20 09:55:18

-----Original Message-----
From: Thomas Monjalon <redacted>
Sent: Monday, January 20, 2020 3:20 AM
To: dev@dpdk.org
Cc: stable@dpdk.org; Rao, Nikhil <redacted>; Chas Williams
[off-list ref]; Richardson, Bruce [off-list ref];
Stephen Hemminger [off-list ref]; Pattan, Reshma
[off-list ref]
Subject: Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is
disabled

Someone to review please?

23/12/2019 07:53, Reshma Pattan:
quoted
Some unit tests has dependency on RING PMD, so this patch is trying to
fix those and other closely related issues.

1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter unit
tests are dependent on ring PMD, so compile those tests only when ring
PMD is enabled else ignore.

2)get rid of make file error which was added by bond unit test for
ring PMD disabled case which is not necessary.

3)Tx adapter UT is dependent on RING PMD, but it was observed that it
was missing from the run in meson build, so added it. TX adapter UT
uses 'sw event and 'null' pmd drivers, so for shared builds the
drivers .so path has to be passed to the test args of meson UT run.

Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library")
Fixes: fdeb30fa71 ("test/bitrate: add unit tests for bitrate library")
Fixes: 1e3676a06e ("test/latency: add unit tests for latencystats
library")
Fixes: 46cf97e4bb ("eventdev: add test for eth Tx adapter")
Fixes: d23e09e0ef ("app/test: link with ring pmd when needed")

CC: stable@dpdk.org
CC: Nikhil Rao <redacted>
CC: Chas Williams <redacted>
CC: Bruce Richardson <redacted>
CC: Stephen Hemminger <stephen@networkplumber.org>

Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Reshma Pattan <redacted>
---
v5: remove extra blank line.
v4: fix event_eth_tx_adapter_autotest for shared build as reported by
travis-ci
https://travis-ci.com/ovsrobot/dpdk/jobs/249598391
v3: add missing test event_eth_tx_adapter_autotest.
Add link bonding mode4 test to drivers test.
v2: fix comments of v1 and combine the patches 1/2 and 2/2 of v1
---
 app/test/Makefile    | 16 +++++-----------
 app/test/meson.build | 36 ++++++++++++++++++++++--------------
 app/test/process.h   |  8 ++++++++
 app/test/test.c      |  2 ++
 4 files changed, 37 insertions(+), 25 deletions(-)
For the fixes related to event_eth_tx_adapter_autotest
Tested-by: Nikhil Rao <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help