Thread (18 messages) 18 messages, 9 authors, 2020-01-20

Re: [dpdk-dev] [PATCH v2] mempool: fix mempool obj alignment for non x86

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2020-01-11 17:42:02

On Sat, 11 Jan 2020 19:04:10 +0530
[off-list ref] wrote:
-#define MEMPOOL_F_NO_SPREAD      0x0001 /**< Do not spread among memory channels. */
+#define MEMPOOL_F_NO_SPREAD      0x0001
+/**< Do not spread among memory channels. It is a hint to the library,
+ * library honor this hint only when, if it is required by the
+ * (micro) architecture.
+ */
That text is awkward for me to read.
There maybe other reasons in future for mempool to ignore the flag.

I prefer the minor change original comment as:
-#define MEMPOOL_F_NO_SPREAD      0x0001 /**< Spreading among memory channels not required. */
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help