Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

Hi Xu

From: Xu, Rosen

Hi Matan,

Did you think about OVS DPDK?
vDPA is a basic module for OVS, currently it will take some exception path
packet processing for OVS, so it still needs to integrate eth_dev.

I don't understand your question.

What do you mean by "integrate eth_dev"?

Thanks,
Rosen

quoted

-----Original Message-----
From: dev <redacted> On Behalf Of Matan Azrad
Sent: Tuesday, January 07, 2020 15:57
To: Matan Azrad <redacted>; Maxime Coquelin
[off-list ref]; Bie, Tiwei [off-list ref]; Wang,
Zhihong [off-list ref]; Wang, Xiao W

[off-list ref]

quoted

Cc: Yigit, Ferruh <redacted>; dev@dpdk.org; Thomas
Monjalon [off-list ref]
Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA
device drivers

Hi all

Any comments?

From: Matan Azrad

quoted

As discussed and as described in RFC "[RFC] net: new vdpa PMD for
Mellanox devices", new vDPA driver is going to be added for Mellanox
devices - vDPA
mlx5 and more.

The only vDPA driver now is the IFC driver that is located in net directory.

The IFC driver and the new vDPA mlx5 driver provide the vDPA ops
introduced in librte_vhost and not the eth-dev ops.
All the others drivers in net class provide the eth-dev ops.
The set of features is also different.

Create a new class for vDPA drivers and move IFC to this class.
Later, all the new drivers that implement the vDPA ops will be added
to the vDPA class.

Also, a vDPA device driver features list was added to vDPA

documentation.

quoted

quoted

Please review the features list and the series.

Later on, I'm going to send the vDPA mlx5 driver.

Thanks.


Matan Azrad (3):
  drivers: introduce vDPA class
  doc: add vDPA feature table
  drivers: move ifc driver to the vDPA class

 MAINTAINERS                               |    6 +-
 doc/guides/conf.py                        |    5 +
 doc/guides/index.rst                      |    1 +
 doc/guides/nics/features/ifcvf.ini        |    8 -
 doc/guides/nics/ifc.rst                   |  106 ---
 doc/guides/nics/index.rst                 |    1 -
 doc/guides/vdpadevs/features/default.ini  |   55 ++
 doc/guides/vdpadevs/features/ifcvf.ini    |    8 +
 doc/guides/vdpadevs/features_overview.rst |   65 ++
 doc/guides/vdpadevs/ifc.rst               |  106 +++
 doc/guides/vdpadevs/index.rst             |   15 +
 drivers/Makefile                          |    2 +
 drivers/meson.build                       |    1 +
 drivers/net/Makefile                      |    3 -
 drivers/net/ifc/Makefile                  |   34 -
 drivers/net/ifc/base/ifcvf.c              |  329 --------
 drivers/net/ifc/base/ifcvf.h              |  162 ----
 drivers/net/ifc/base/ifcvf_osdep.h        |   52 --
 drivers/net/ifc/ifcvf_vdpa.c              | 1280 -----------------------------
 drivers/net/ifc/meson.build               |    9 -
 drivers/net/ifc/rte_pmd_ifc_version.map   |    3 -
 drivers/net/meson.build                   |    1 -
 drivers/vdpa/Makefile                     |   14 +
 drivers/vdpa/ifc/Makefile                 |   34 +
 drivers/vdpa/ifc/base/ifcvf.c             |  329 ++++++++
 drivers/vdpa/ifc/base/ifcvf.h             |  162 ++++
 drivers/vdpa/ifc/base/ifcvf_osdep.h       |   52 ++
 drivers/vdpa/ifc/ifcvf_vdpa.c             | 1280
+++++++++++++++++++++++++++++
 drivers/vdpa/ifc/meson.build              |    9 +
 drivers/vdpa/ifc/rte_pmd_ifc_version.map  |    3 +
 drivers/vdpa/meson.build                  |    8 +
 31 files changed, 2152 insertions(+), 1991 deletions(-)  delete
mode
100644 doc/guides/nics/features/ifcvf.ini
 delete mode 100644 doc/guides/nics/ifc.rst  create mode 100644
doc/guides/vdpadevs/features/default.ini
 create mode 100644 doc/guides/vdpadevs/features/ifcvf.ini
 create mode 100644 doc/guides/vdpadevs/features_overview.rst
 create mode 100644 doc/guides/vdpadevs/ifc.rst  create mode 100644
doc/guides/vdpadevs/index.rst  delete mode 100644
drivers/net/ifc/Makefile  delete mode 100644
drivers/net/ifc/base/ifcvf.c delete mode 100644
drivers/net/ifc/base/ifcvf.h  delete mode 100644
drivers/net/ifc/base/ifcvf_osdep.h
 delete mode 100644 drivers/net/ifc/ifcvf_vdpa.c  delete mode 100644
drivers/net/ifc/meson.build  delete mode 100644
drivers/net/ifc/rte_pmd_ifc_version.map
 create mode 100644 drivers/vdpa/Makefile  create mode 100644
drivers/vdpa/ifc/Makefile  create mode 100644
drivers/vdpa/ifc/base/ifcvf.c create mode 100644
drivers/vdpa/ifc/base/ifcvf.h  create mode 100644
drivers/vdpa/ifc/base/ifcvf_osdep.h
 create mode 100644 drivers/vdpa/ifc/ifcvf_vdpa.c  create mode
100644 drivers/vdpa/ifc/meson.build  create mode 100644
drivers/vdpa/ifc/rte_pmd_ifc_version.map
 create mode 100644 drivers/vdpa/meson.build

--
1.8.3.1