Re: [dpdk-dev] [EXT] [PATCH] cryptodev: extend api of asymmetric crypto by sessionless
From: Anoob Joseph <hidden>
Date: 2019-08-12 09:26:31
Hi Arek, Please see inline. Thanks, Anoob
quoted hunk ↗ jump to hunk
-----Original Message----- From: dev <redacted> On Behalf Of Arek Kusztal Sent: Tuesday, June 4, 2019 1:14 AM To: dev@dpdk.org Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; shally.verma@caviumnetworks.com; Arek Kusztal [off-list ref] Subject: [EXT] [dpdk-dev] [PATCH] cryptodev: extend api of asymmetric crypto by sessionless External Email ---------------------------------------------------------------------- Asymmetric cryptography algorithms may more likely use sessionless API so there is need to extend API. Signed-off-by: Arek Kusztal <redacted> --- lib/librte_cryptodev/rte_crypto_asym.h | 2 ++ 1 file changed, 2 insertions(+)diff --git a/lib/librte_cryptodev/rte_crypto_asym.hb/lib/librte_cryptodev/rte_crypto_asym.h index 8672f21..5d69692 100644--- a/lib/librte_cryptodev/rte_crypto_asym.h +++ b/lib/librte_cryptodev/rte_crypto_asym.h@@ -503,6 +503,8 @@ struct rte_crypto_dsa_op_param { structrte_crypto_asym_op { struct rte_cryptodev_asym_session *session; /**< Handle for the initialised session context */ + struct rte_crypto_asym_xform *xform; + /**< Session-less API crypto operation parameters */
[Anoob] Shouldn't we make this a union? In symmetric mode, it is done that way and it makes sense also.
Something like,
RTE_STD_C11
union {
struct rte_cryptodev_asym_session *session;
/**< Handle for the initialised session context */
struct rte_crypto_asym_xform *xform;
/**< Session-less API crypto operation parameters */
};
__extension__
union {
--
2.7.4